gh-yzou commented on code in PR #2294:
URL: https://github.com/apache/polaris/pull/2294#discussion_r2271712169
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -122,27 +131,58 @@ public void addTaskHandlerContext(long taskEntityId,
CallContext callContext) {
// the task is still running.
// Note: PolarisCallContext has request-scoped beans as well, and must be
cloned.
// FIXME replace with context propagation?
- CallContext clone = callContext.copy();
- tryHandleTask(taskEntityId, clone, null, 1);
+ tryHandleTask(taskEntityId, new TaskContext(callContext), null, 1);
+ }
+
+ record TaskContext(String realmId, PolarisDiagnostics diagnostics) {
Review Comment:
have we done some testing (at least manually to verify the task is still
executing correctly)? as far as I know, we currently do not have a good
integration test that actually helps verify the background task. The regtests
t_pyspark/test_spark_sql_s3_with_privileges.py contains a tests that helps
verify the background purge task, but not running in the CI today.
Can we follow up the readme here
https://github.com/apache/polaris/blob/main/regtests/README.md to run the test
against aws to verify things are still working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
