RussellSpitzer commented on PR #1965: URL: https://github.com/apache/polaris/pull/1965#issuecomment-3169138547
Hi y'all, I'm a bit late to this discussion but i'm a little confused around a few issues Mostly this centers around the Futures tracking we are doing, 1. Why do we need to do our own app level retries of AWS requests? Doesn't the Cloudwatch SDK provide retries and policy that we can configure if we wanted additional retries? I'm not sure the complexity here is worth while since we don't have any app logic that needs to get redone when a retry happens. I'm not opposed to doing the retries on the app side, i'm just not sure why they are necessary. 2. Why do we need to reap futures at all? Do we not trust Quarkus to shutdown the executor service appropriately? It seems a bit counter-intuitive to me that we would be provided an ExecutorService by the runtime but then in case of emergency we need to manually manage it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
