MonkeyCanCode opened a new pull request, #2287:
URL: https://github.com/apache/polaris/pull/2287
Currently when running `--repair` with client, it will produce following
message
```
➜ polaris git:(client_repair_mode) ./polaris --repair
Configuration on demand is an incubating feature.
> Task :regeneratePythonClient
...
Writing lock file
Installing the current project: polaris (1.0.0)
Dependencies repaired.
Traceback (most recent call last):
File "/Users/yong/Desktop/GitHome/polaris/polaris-venv/bin/polaris", line
6, in <module>
sys.exit(main())
~~~~^^
File
"/Users/yong/Desktop/GitHome/polaris/client/python/cli/polaris_cli.py", line
219, in main
PolarisCli.execute()
~~~~~~~~~~~~~~~~~~^^
File
"/Users/yong/Desktop/GitHome/polaris/client/python/cli/polaris_cli.py", line
70, in execute
client_builder = PolarisCli._get_client_builder(options)
File
"/Users/yong/Desktop/GitHome/polaris/client/python/cli/polaris_cli.py", line
175, in _get_client_builder
raise Exception(
...<5 lines>...
)
Exception: Please provide credentials via either --client-id &
--client-secret or --access-token. Alternatively, you may set the environment
variables CLIENT_ID & CLIENT_SECRET.
```
This is bad user experience as we are not expecting user to run the main CLI
during repair mode. Thus. it is better to clean exit if repair mode is invoked
to avoid confusion.
With this PR, we will know have following instead:
```
...
No dependencies to install or update
Writing lock file
Installing the current project: polaris (1.0.0)
Dependencies repaired.
➜ polaris git:(client_repair_mode) ✗
```
This PR also fixed a logic flaw in the first time setup complete message
that will never happened with original code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
