HonahX commented on code in PR #2048: URL: https://github.com/apache/polaris/pull/2048#discussion_r2248421514
########## polaris-core/src/main/java/org/apache/polaris/core/policy/content/AccessControlPolicyContent.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.policy.content; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.fasterxml.jackson.databind.annotation.JsonSerialize; +import com.google.common.base.Strings; +import java.util.List; +import java.util.Set; +import org.apache.iceberg.expressions.Expression; +import org.apache.polaris.core.policy.validator.InvalidPolicyException; + +public class AccessControlPolicyContent implements PolicyContent { Review Comment: I think we can have a separate discussion for this in the community about the adoption/direction to use Immutable objects in the future. For this PR I think be consistent with existing data structure is fine. ########## polaris-core/src/main/java/org/apache/polaris/core/policy/validator/PolicyValidators.java: ########## @@ -98,6 +102,10 @@ public static boolean canAttach(PolicyEntity policy, PolarisEntity targetEntity) case ORPHAN_FILE_REMOVAL: return BaseMaintenancePolicyValidator.INSTANCE.canAttach(entityType, entitySubType); + case ACCESS_CONTROL: + // TODO: Add validator for attaching this only to table + return true; Review Comment: We probably need to pass in callContext or at least the configuration store to make this default to false and can be manually turned on for POC purpose, until we implement the validator for attaching this policy only to table. ########## polaris-core/src/main/java/org/apache/polaris/core/policy/content/AccessControlPolicyContent.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.policy.content; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.annotation.JsonDeserialize; +import com.fasterxml.jackson.databind.annotation.JsonSerialize; +import com.google.common.base.Strings; +import java.util.List; +import java.util.Set; +import org.apache.iceberg.expressions.Expression; +import org.apache.polaris.core.policy.validator.InvalidPolicyException; + +public class AccessControlPolicyContent implements PolicyContent { + + // Optional, if there means policies is applicable to the role + private String principalRole; + + // TODO: model them as iceberg transforms + private List<String> columnProjections; + + // Iceberg expressions without context functions for now. + // Use a custom deserializer for the list of Iceberg Expressions + @JsonDeserialize(using = IcebergExpressionListDeserializer.class) + @JsonSerialize(using = IcebergExpressionListSerializer.class) Review Comment: This seems fine to me given that `Expression` is also defined in the IRC spec: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L2162. So Iceberg side need to make sure any changes there won't violate the spec. We've also depends on CatalogHandler, RestResponse, TableIdentifier, and other classes/models from iceberg. We can change to a custom one later if we need some customizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
