snazy commented on code in PR #2262:
URL: https://github.com/apache/polaris/pull/2262#discussion_r2256099108
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -268,45 +268,6 @@ List<PolarisBaseEntity> lookupEntities(
List<PolarisChangeTrackingVersions> lookupEntityVersions(
@Nonnull PolarisCallContext callCtx, List<PolarisEntityId> entityIds);
- /**
- * List all entities of the specified type which are child entities of the
specified parent
- *
- * @param callCtx call context
- * @param catalogId catalog id for that entity, NULL_ID if the entity is
top-level
- * @param parentId id of the parent, can be the special 0 value representing
the root entity
- * @param entityType type of entities to list
- * @param pageToken the token to start listing after
- * @return the list of entities for the specified list operation
- */
- @Nonnull
- Page<EntityNameLookupRecord> listEntities(
Review Comment:
This particular type is actually not even used by any production code
outside of a particular persistence implementation.
If a particular implementation needs more functions, those implementations
are free to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
