adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251696582
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
Yes :-( there are similarly-named inner classes in `OidcTenantConfiguration`.
##########
runtime/service/src/test/java/org/apache/polaris/service/auth/external/PrincipalAuthInfoAugmentorTest.java:
##########
@@ -32,39 +32,38 @@
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Set;
-import
org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalMapper;
-import
org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
-import
org.apache.polaris.service.quarkus.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
+import
org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalMapper;
+import
org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
+import
org.apache.polaris.service.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
import org.eclipse.microprofile.jwt.JsonWebToken;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
class PrincipalAuthInfoAugmentorTest {
private PrincipalAuthInfoAugmentor augmentor;
- private
org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalMapper
principalMapper;
- private
org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalRolesMapper
+ private org.apache.polaris.service.auth.external.mapping.PrincipalMapper
principalMapper;
+ private org.apache.polaris.service.auth.external.mapping.PrincipalRolesMapper
Review Comment:
Yes :-( there are similarly-named inner classes in OidcTenantConfiguration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
