gh-yzou commented on code in PR #2239:
URL: https://github.com/apache/polaris/pull/2239#discussion_r2249031204


##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##########
@@ -182,6 +188,9 @@ public Table alterTable(Identifier ident, TableChange... 
changes) throws NoSuchT
         //     using ALTER TABLE ...SET LOCATION, and ALTER TABLE ... SET 
FILEFORMAT.
         TableCatalog deltaCatalog = 
deltaHelper.loadDeltaCatalog(this.polarisSparkCatalog);
         return deltaCatalog.alterTable(ident, changes);
+      } else if (PolarisCatalogUtils.useLance(provider)) {
+        TableCatalog lanceCatalog = 
lanceHelper.loadLanceCatalog(this.polarisSparkCatalog);

Review Comment:
   do we have limitations on alter operations like what we have mentioned for 
delta?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to