snazy commented on code in PR #2235:
URL: https://github.com/apache/polaris/pull/2235#discussion_r2248277534
##########
service/common/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java:
##########
@@ -81,27 +85,32 @@ public PolarisStorageIntegrationProviderImpl(
case S3:
storageIntegration =
(PolarisStorageIntegration<T>)
- new AwsCredentialsStorageIntegration(stsClientProvider,
stsCredentials);
+ new AwsCredentialsStorageIntegration(
+ (AwsStorageConfigurationInfo)
polarisStorageConfigurationInfo,
+ stsClientProvider,
+ stsCredentials);
break;
case GCS:
storageIntegration =
(PolarisStorageIntegration<T>)
new GcpCredentialsStorageIntegration(
+ (GcpStorageConfigurationInfo)
polarisStorageConfigurationInfo,
gcpCredsProvider.get(),
ServiceOptions.getFromServiceLoader(
HttpTransportFactory.class, NetHttpTransport::new));
break;
case AZURE:
storageIntegration =
- (PolarisStorageIntegration<T>) new
AzureCredentialsStorageIntegration();
+ (PolarisStorageIntegration<T>)
+ new AzureCredentialsStorageIntegration(
+ (AzureStorageConfigurationInfo)
polarisStorageConfigurationInfo);
break;
case FILE:
storageIntegration =
- new PolarisStorageIntegration<>("file") {
+ new PolarisStorageIntegration<>((T)
polarisStorageConfigurationInfo, "file") {
Review Comment:
Yea, but javac is a bit opinionated here ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
