XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2237557094
########## polaris-core/src/main/java/org/apache/polaris/core/secrets/ServiceSecretReference.java: ########## Review Comment: I extended `UserSecretReference` and introduced a new class `ServiceSecretReference`, to better reflect the purpose of the reference. I'm open to renaming it. The URN format check remains the same (`urn:polaris-secret:xxx:xxx`). To make this more flexible and reusable, we could introduce a base class called `SecretReference`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
