pingtimeout commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2227892558
########## releasey/04-build-and-test.sh: ########## @@ -0,0 +1,118 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# +# Build and Test Script +# +# Builds Polaris completely and runs regression tests to verify the release. +# Cloud-specific tests are disabled by default and require proper credentials +# to be configured in the environment. +# Review Comment: @snazy Just to be sure, could you help me confirm that "Combined status" is not the right thing for what we are trying to do? When I look at the combined status of any commit from `main`, the `state` property is always `pending`. Now, digging around, I found that there is a REST API endpoint to [verify the "Checks" that have been run against a particular commit](https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-for-a-git-reference). Example for a commit of this PR where `./gradlew rat` failed one of the checks: there is one `failure`. ``` $ curl -s -H "Authorization: Bearer ${GITHUB_REPO_STATUS_TOKEN}" -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/apache/polaris/commits/5d0c1c2/check-runs | jq '.check_runs[].conclusion' "skipped" "failure" "success" "success" "success" "success" "success" "success" "success" "success" "success" "success" ``` And for a Renovate commit that was just pushed to `main`: everything is `success`. ``` $ curl -s -H "Authorization: Bearer ${GITHUB_REPO_STATUS_TOKEN}" -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/apache/polaris/commits/98d42205e/check-runs | jq '.check_runs[].conclusion' "success" "success" "success" "success" "success" "success" "success" "success" "success" "success" "success" "success" ``` So I am thinking that this verification should be "the conclusion of all checks should be `success`". Is that what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
