XN137 commented on code in PR #2162:
URL: https://github.com/apache/polaris/pull/2162#discussion_r2224931172
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -160,12 +159,8 @@ public synchronized Supplier<TransactionalPersistence>
getOrCreateSessionSupplie
RealmContext realmContext) {
if (!sessionSupplierMap.containsKey(realmContext.getRealmIdentifier())) {
initializeForRealm(realmContext, null);
- checkPolarisServiceBootstrappedForRealm(
- realmContext,
metaStoreManagerMap.get(realmContext.getRealmIdentifier()));
- } else {
- checkPolarisServiceBootstrappedForRealm(
- realmContext,
metaStoreManagerMap.get(realmContext.getRealmIdentifier()));
}
+ checkPolarisServiceBootstrappedForRealm(realmContext);
Review Comment:
note that since b069591c19e99743ace09fdf2cfda65654728473 this call was
happening in both if branches, so we can move it to the outside.
but imo this fact raises the question why `getOrCreateMetaStoreManager`
still only calls it on the inside.
(same problem exists in the copy-pasted jdbc variant)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
