eric-maynard commented on code in PR #2106:
URL: https://github.com/apache/polaris/pull/2106#discussion_r2211054447
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/AbstractPolicyCatalogTest.java:
##########
@@ -108,24 +103,7 @@
import software.amazon.awssdk.services.sts.model.AssumeRoleResponse;
import software.amazon.awssdk.services.sts.model.Credentials;
-@QuarkusTest
-@TestProfile(PolicyCatalogTest.Profile.class)
-public class PolicyCatalogTest {
- public static class Profile implements QuarkusTestProfile {
-
- @Override
- public Map<String, String> getConfigOverrides() {
- return Map.of(
- "polaris.features.\"ALLOW_SPECIFYING_FILE_IO_IMPL\"",
- "true",
- "polaris.features.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
- "[\"FILE\"]",
- "polaris.features.\"ALLOW_INSECURE_STORAGE_TYPES\"",
- "true",
- "polaris.readiness.ignore-severe-issues",
- "true");
- }
- }
+public abstract class AbstractPolicyCatalogTest {
Review Comment:
The pattern we follow in other tests seems to be `...Base` such as in
`BootstrapCommandTestBase`, perhaps we'd better follow that convention rather
than introduce a new `Abstract...` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
