eric-maynard commented on code in PR #1965:
URL: https://github.com/apache/polaris/pull/1965#discussion_r2210734631
##########
service/common/src/main/java/org/apache/polaris/service/events/PolarisEventListener.java:
##########
@@ -55,4 +57,7 @@ public void onBeforeTaskAttempted(BeforeTaskAttemptedEvent
event) {}
/** {@link AfterTaskAttemptedEvent} */
public void onAfterTaskAttempted(AfterTaskAttemptedEvent event) {}
+
+ /** {@link AfterCatalogCreatedEvent} */
+ public void onAfterCatalogCreated(AfterCatalogCreatedEvent event,
CallContext callContext) {}
Review Comment:
Got it, that makes sense -- we need working unit tests. My preference would
still be to make the event changes separately and then rebase this PR on top of
main once those changes merge, but I won't go so far as to say this change must
be removed from the current PR since that would break tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
