eric-maynard commented on code in PR #2048:
URL: https://github.com/apache/polaris/pull/2048#discussion_r2208803242
##########
polaris-core/src/main/java/org/apache/polaris/core/policy/PredefinedPolicyTypes.java:
##########
@@ -28,7 +28,8 @@ public enum PredefinedPolicyTypes implements PolicyType {
DATA_COMPACTION(0, "system.data-compaction", true),
METADATA_COMPACTION(1, "system.metadata-compaction", true),
ORPHAN_FILE_REMOVAL(2, "system.orphan-file-removal", true),
- SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true);
+ SNAPSHOT_EXPIRY(3, "system.snapshot-expiry", true),
+ ACCESS_CONTROL(4, "system.access-control", false);
Review Comment:
IIUC we'll use the same policy to also have non-expression based filtering,
but I think that something like `TABLE_ACCESS` or `TABLE_DATA_ACCESS` is a good
idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
