eric-maynard commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2208030389
########## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.config; + +import jakarta.annotation.Nullable; +import org.apache.polaris.core.context.RealmContext; +import org.apache.polaris.core.entity.CatalogEntity; + +public class RealmConfigImpl implements RealmConfig { + + private final PolarisConfigurationStore configurationStore; Review Comment: Looks like @snazy merged this, but in response to the above: > don't you also agree that having "realm-scoped wrappers" around "multi-realm implementation details" simplifies code that operates strictly within a single realm? No, not really -- all callers will now just use `RealmConfig`, so `PolarisConfigurationStore` becomes unnecessary. Yes, it is used to implement `RealmConfig`, but we need to consider which is a better interface to prospective callers who want to load a config. Is it `RealmConfig` and its methods or `PolarisConfigurationStore`? Probably the latter, which could have been extended into some `RealmConfigurationStore` which includes methods to load configs without you having to pass in a realm. > as there can be realm-specific overrides which take precedence. Is there a case today where we pass in a realm other than the one which would get injected? That is the only situation where I see someone wanting to directly interface with `PolarisConfigurationStore` now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
