dimas-b commented on code in PR #2023:
URL: https://github.com/apache/polaris/pull/2023#discussion_r2197550502
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -450,42 +446,6 @@ protected boolean supportsNotifications() {
return true;
}
- private MetaStoreManagerFactory createMockMetaStoreManagerFactory() {
- return new MetaStoreManagerFactory() {
- @Override
- public PolarisMetaStoreManager getOrCreateMetaStoreManager(RealmContext
realmContext) {
- return metaStoreManager;
- }
-
- @Override
- public Supplier<TransactionalPersistence> getOrCreateSessionSupplier(
- RealmContext realmContext) {
- return () -> ((TransactionalPersistence)
polarisContext.getMetaStore());
- }
-
- @Override
- public StorageCredentialCache
getOrCreateStorageCredentialCache(RealmContext realmContext) {
- return new StorageCredentialCache(realmContext, configurationStore);
- }
-
- @Override
- public InMemoryEntityCache getOrCreateEntityCache(RealmContext
realmContext) {
- return new InMemoryEntityCache(realmContext, configurationStore,
metaStoreManager);
- }
-
- @Override
- public Map<String, PrincipalSecretsResult> bootstrapRealms(
- Iterable<String> realms, RootCredentialsSet rootCredentialsSet) {
- throw new NotImplementedException("Bootstrapping realms is not
supported");
Review Comment:
I do not see any test relying on this exception, so removing this piece of
code LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
