XN137 commented on PR #2015: URL: https://github.com/apache/polaris/pull/2015#issuecomment-3053151996
> I don't think the new invocation is really ideal: x.getRealmConfig().getConfig(y). Is the return value of getRealmConfig the "config" or the return value of getConfig(y)? They both seem to claim they're fetching a config. `PolarisConfigurationStore.getConfiguration` is also returning configuration values and not a configuration and certainly not a `PolarisConfiguration` (which is a parameter not a return value). :sweat_smile: but you are right, i also wasnt very convinced of the `getConfig` name, would you prefer `getConfigValue` or `getValue` or maybe just `get`? would any of those address your concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
