pavibhai commented on code in PR #1424:
URL: https://github.com/apache/polaris/pull/1424#discussion_r2195117703


##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow(
                   + "in their snapshot summary")
           .defaultValue(false)
           .buildFeatureConfiguration();
+
+  public static final FeatureConfiguration<Boolean> ENABLE_KMS_SUPPORT_FOR_S3 =

Review Comment:
   yes, just the 
[`s3:GetEncryptionConfiguration`](https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketEncryption.html)
 I don't see that as being an issue. Do you see any concerns in providing that 
permission?
   
   IMO, it is a big plus if we can avoid duplicating this information into 
Polaris.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to