snazy commented on code in PR #25:
URL: https://github.com/apache/polaris-tools/pull/25#discussion_r2194761297
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/NamespaceActions.scala:
##########
@@ -206,15 +206,15 @@ case class NamespaceActions(
* structure.
*/
val fetchAllChildrenNamespaces: ChainBuilder = exec(
- http("Fetch all Namespaces under specific parent")
+ http("Fetch children Namespaces")
.get("/api/catalog/v1/#{catalogName}/namespaces?parent=#{namespaceMultipartPath}")
.header("Authorization", "Bearer #{accessToken}")
.check(status.is(200))
)
val updateNamespaceProperties: ChainBuilder =
- retryOnHttpStatus(maxRetries, retryableHttpCodes, "Update namespace
properties")(
- http("Update Namespace Properties")
+ retryOnHttpStatus(maxRetries, retryableHttpCodes, "Update Namespace")(
Review Comment:
```suggestion
retryOnHttpStatus(maxRetries, retryableHttpCodes, "Update namespace")(
```
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/NamespaceActions.scala:
##########
@@ -206,15 +206,15 @@ case class NamespaceActions(
* structure.
*/
val fetchAllChildrenNamespaces: ChainBuilder = exec(
- http("Fetch all Namespaces under specific parent")
+ http("Fetch children Namespaces")
Review Comment:
Since we're in the fix-the-typo land ...
```suggestion
http("Fetch child namespaces")
```
;)
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/TableActions.scala:
##########
@@ -149,7 +149,7 @@ case class TableActions(
*
* There is no limit to the number of users that can create tables
concurrently.
*/
- val createTable: ChainBuilder = retryOnHttpStatus(maxRetries,
retryableHttpCodes, "Create table")(
+ val createTable: ChainBuilder = retryOnHttpStatus(maxRetries,
retryableHttpCodes, "Create Table")(
Review Comment:
more nouns :P
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/NamespaceActions.scala:
##########
@@ -173,7 +173,7 @@ case class NamespaceActions(
* There is no limit to the number of users that can fetch namespaces
concurrently.
*/
val fetchNamespace: ChainBuilder = exec(
- http("Fetch Namespace")
+ http("Fetch single Namespace")
Review Comment:
```suggestion
http("Fetch single namespace")
```
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/NamespaceActions.scala:
##########
@@ -206,15 +206,15 @@ case class NamespaceActions(
* structure.
*/
val fetchAllChildrenNamespaces: ChainBuilder = exec(
- http("Fetch all Namespaces under specific parent")
+ http("Fetch children Namespaces")
.get("/api/catalog/v1/#{catalogName}/namespaces?parent=#{namespaceMultipartPath}")
.header("Authorization", "Bearer #{accessToken}")
.check(status.is(200))
)
val updateNamespaceProperties: ChainBuilder =
- retryOnHttpStatus(maxRetries, retryableHttpCodes, "Update namespace
properties")(
- http("Update Namespace Properties")
+ retryOnHttpStatus(maxRetries, retryableHttpCodes, "Update Namespace")(
+ http("Update Namespace")
Review Comment:
```suggestion
http("Update namespace")
```
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/NamespaceActions.scala:
##########
@@ -147,7 +147,7 @@ case class NamespaceActions(
* Typically, start 1 user and increase by 1 user every second until some
arbitrary maximum value.
*/
val createNamespace: ChainBuilder =
- retryOnHttpStatus(maxRetries, retryableHttpCodes, "Create namespace")(
+ retryOnHttpStatus(maxRetries, retryableHttpCodes, "Create Namespace")(
Review Comment:
```suggestion
retryOnHttpStatus(maxRetries, retryableHttpCodes, "Create namespace")(
```
nouns are lower case in english ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
