eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2193908312
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -71,21 +76,23 @@ public AwsStorageConfigurationInfo(
@JsonProperty(value = "externalId") @Nullable String externalId,
@JsonProperty(value = "region", required = false) @Nullable String
region,
@JsonProperty(value = "endpoint") @Nullable String endpoint,
- @JsonProperty(value = "stsEndpoint") @Nullable String stsEndpoint) {
+ @JsonProperty(value = "stsEndpoint") @Nullable String stsEndpoint,
+ @JsonProperty(value = "pathStyleAccess") @Nullable Boolean
pathStyleAccess) {
super(storageType, allowedLocations);
this.roleARN = roleARN;
this.externalId = externalId;
this.region = region;
this.endpoint = endpoint;
this.stsEndpoint = stsEndpoint;
+ this.pathStyleAccess = Optional.ofNullable(pathStyleAccess).orElse(false);
}
public AwsStorageConfigurationInfo(
@Nonnull StorageType storageType,
@Nonnull List<String> allowedLocations,
@Nonnull String roleARN,
@Nullable String region) {
- this(storageType, allowedLocations, roleARN, null, region, null, null);
+ this(storageType, allowedLocations, roleARN, null, region, null, null,
false);
Review Comment:
We could use the default here, or just leave it null to leverage the default
used in `orElse`. Better not to proliferate the constants around like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
