poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2192851849
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration<T> extends
PolarisConfiguration<T> {
protected BehaviorChangeConfiguration(
String key,
Review Comment:
Here is my understanding: A PolarisConfiguration or a configuration for any
quarkus app has a `name` (`key` in PoalrisConfiguration) that is used to
identify it. The key/name is the identity of the configuration. The point of
adding support for legacyKeys was to enable identity changes wherein we can for
certain time support deprecated keys. I don't see why we should have **multiple
identifying keys** mapping to a **single entity**. If you ever need multiple
identities, then the legacy keys do support the need but eventually each entity
must converge to a single identity.
Please let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
