dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2190983846
##########
LICENSE:
##########
@@ -222,6 +222,7 @@ This product includes code from Apache Iceberg.
*
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
*
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisRESTCatalog.java
*
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java
+*
service/common/src/main/java/org/apache/polaris/service/catalog/common/LocationUtils.java
Review Comment:
nit: maybe keep this together with the other `service/common/*` references?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
+ "to enforce this when new locations are added. Only
supported by the JDBC metastore.")
.defaultValue(false)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean>
DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED =
+ PolarisConfiguration.<Boolean>builder()
+ .key("DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED")
Review Comment:
Why is it "DEFAULT"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
