MonkeyCanCode commented on PR #2002: URL: https://github.com/apache/polaris/pull/2002#issuecomment-3045959805
> Thanks @MonkeyCanCode for this change. > > I'm generally OK with it, but this is a breaking change in the Helm chart, and since it will be released after 1.0.0, I wonder if we shouldn't proceed with some caution here. > > I see a few options: > > * Allow the breaking change and mention it in the changelog file. > * Keep the old fields around and deprecate them for removal. > > Wdyt? I think that is fair (thought as we tried to get to 1.0.0 release, thus introduced this breaking change before that happened). But think that is reasonable to keep it backward compatible. Let me update this helm chart to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
