eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2176197646
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -263,12 +264,14 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
- public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
- PolarisConfiguration.<List<String>>builder()
- .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
- .description("The list of supported catalog connection types for
federation")
- .defaultValue(List.of(ConnectionType.ICEBERG_REST.name()))
- .buildFeatureConfiguration();
+ public static final FeatureConfiguration<List<String>>
+ SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES")
+ .deprecatedKey("SUPPORTED_CATALOG_CONNECTION_TYPES")
Review Comment:
Whether we use one `key` call that takes N strings or we allow `N` chained
calls to `key` / `deprecatedKey`, the point is we should support N different
keys rather than 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
