dimas-b commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2175641847
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -112,6 +112,7 @@
polaris.features."ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING"=false
polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES"=["S3","GCS","AZURE"]
# polaris.features."ENABLE_CATALOG_FEDERATION"=true
polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"]
+polaris.features."ENABLE_EXTERNAL_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"]
Review Comment:
Is this change relevant to current PR's scope (and title)?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -263,12 +264,14 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
- public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
- PolarisConfiguration.<List<String>>builder()
- .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
- .description("The list of supported catalog connection types for
federation")
- .defaultValue(List.of(ConnectionType.ICEBERG_REST.name()))
- .buildFeatureConfiguration();
+ public static final FeatureConfiguration<List<String>>
+ SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES")
+ .deprecatedKey("SUPPORTED_CATALOG_CONNECTION_TYPES")
Review Comment:
I'd prefer a name like `.legacyKey()` or `.compatibilityKey()` for the sake
of clarity. "Deprecated" key as a builder parameter does not convey a reason
for this key to exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
