eric-maynard commented on code in PR #1942:
URL: https://github.com/apache/polaris/pull/1942#discussion_r2167787733
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -108,18 +115,19 @@ private void initializeForRealm(
metaStoreManagerMap.put(realmContext.getRealmIdentifier(),
metaStoreManager);
}
- private DatasourceOperations getDatasourceOperations(boolean isBootstrap) {
+ private DatasourceOperations getDatasourceOperations(Optional<SchemaOptions>
schemaOptions) {
DatasourceOperations databaseOperations;
try {
databaseOperations = new DatasourceOperations(dataSource.get(),
relationalJdbcConfiguration);
} catch (SQLException sqlException) {
throw new RuntimeException(sqlException);
}
- if (isBootstrap) {
+ // If this is set, we are bootstrapping
+ if (schemaOptions.isPresent()) {
Review Comment:
Looking, I only pulled the script execution up one level into
`bootstrapRealms` rather than into the admin tool itself -- though it only runs
as a result of that admin tool code path. If we want to pull the logic out of
even `bootstrapRealms` I think we may need to do some refactoring to
`MetaStoreManagerFactory` which I would prefer to avoid doing in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
