HotSushi commented on code in PR #1934: URL: https://github.com/apache/polaris/pull/1934#discussion_r2167641505
########## runtime/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogAwsIntegrationTest.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.quarkus.it; + +import io.quarkus.test.junit.QuarkusTest; +import io.quarkus.test.junit.QuarkusTestProfile; +import io.quarkus.test.junit.TestProfile; +import java.util.Map; +import org.apache.polaris.service.it.test.PolarisRestCatalogAwsIntegrationTest; + +@QuarkusTest +@TestProfile(QuarkusRestCatalogAwsIntegrationTest.Profile.class) +public class QuarkusRestCatalogAwsIntegrationTest extends PolarisRestCatalogAwsIntegrationTest { Review Comment: Makes sense—I was wondering about the duplication of tests. I've removed the cloud-specific `@QuarkusTests` instances, except for the file-based one, which is handy for debugging and fits more into the unit test category rather than an integration test. Let me know if you feel strongly about removing that as well. ########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java: ########## @@ -214,14 +212,17 @@ public void before(TestInfo testInfo) { Method method = testInfo.getTestMethod().orElseThrow(); currentCatalogName = client.newEntityName(method.getName()); - AwsStorageConfigInfo awsConfigModel = - AwsStorageConfigInfo.builder() - .setRoleArn(TEST_ROLE_ARN) - .setExternalId("externalId") - .setUserArn("a:user:arn") - .setStorageType(StorageConfigInfo.StorageTypeEnum.S3) - .setAllowedLocations(List.of("s3://my-old-bucket/path/to/data")) - .build(); + StorageConfigInfo storageConfig = getStorageConfigInfo(); + catalogBaseLocation = + storageConfig.getAllowedLocations().getFirst() + + "/" + + System.getenv("USER") Review Comment: Done! PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
