flyrain commented on code in PR #1944: URL: https://github.com/apache/polaris/pull/1944#discussion_r2167585393
########## helm/polaris/Chart.yaml: ########## @@ -21,8 +21,8 @@ apiVersion: v2 name: polaris description: A Helm chart for Apache Polaris (incubating) type: application -version: 0.1.0 -appVersion: 1.0.0-incubating-SNAPSHOT +version: 1.0.0 +appVersion: 1.0.0-incubating Review Comment: Here is an example, which assumes Helm chart version matched with Polaris src/bin/docker version: 1. When an user revert to the Helm Chart v1.0.0, it still points the `latest` docker image, which could be 1.1.0 already. This introduces the incompatible risks. On the other hand, if we specified a version(e.g., 1.0.0) instead of `latest`, the Helm reversion will always be same. 2. if people install the latest version of the helm chart, it still points to the latest docker image as we release them together. So that use case is covered as well. With that, I think specifying a version is preferrable than `latest`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
