flyrain commented on code in PR #1926:
URL: https://github.com/apache/polaris/pull/1926#discussion_r2165262003


##########
runtime/distribution/build.gradle.kts:
##########
@@ -104,6 +104,7 @@ distZip.configure { finalizedBy(digestDistZip) }
 
 if (project.hasProperty("release") || project.hasProperty("signArtifacts")) {
     signing {
+        useGpgCmd();

Review Comment:
   Tested multiple times. Here are commands I am using:
   ```
   ./gradlew clean
   ./gradlew build sourceTarball -Prelease -PuseGpgAgent -x test -x intTest
   ```
   
   It always failed without this change, error message: 
   ```
   > Task :polaris-distribution:signDistTar FAILED
   
   [Incubating] Problems report is available at: 
file:///Users/ygu/asf/polaris/build/reports/problems/problems-report.html
   
   FAILURE: Build failed with an exception.
   
   * What went wrong:
   Execution failed for task ':polaris-distribution:signDistTar'.
   > Cannot perform signing task ':polaris-distribution:signDistTar' because it 
has no configured signatory
   ```
   
   And it always passed with the change. Can you double check? Maybe share your 
gpg setting if the results are different.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to