eric-maynard commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2164483231
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationType.java:
##########
@@ -33,6 +33,7 @@ public enum AuthenticationType {
NULL_TYPE(0),
OAUTH(1),
BEARER(2),
+ NO_AUTH(3),
Review Comment:
With some connection types like HIVE, you may either have or not have an
authentication mechanism in place. It's reasonable that admins might want to
limit which authentication types can be used for their service (e.g. disallow
auth-less federation), but they can't disallow having a `null` authentication
type because that is also used by "classic" EXTERNAL catalogs that don't
federate at all.
In other words, if you have a non-null connection, you should have a
non-null authentication type configured. We should still leave room however for
users to be explicit about certain federation modes like HIVE that may not have
authentication in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
