eric-maynard commented on code in PR #21:
URL: https://github.com/apache/polaris-tools/pull/21#discussion_r2150600152
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/parameters/DatasetParameters.scala:
##########
@@ -54,7 +54,7 @@ case class DatasetParameters(
numViewProperties: Int
) {
val nAryTree: NAryTreeBuilder = NAryTreeBuilder(nsWidth, nsDepth)
- private val maxPossibleTables = nAryTree.numberOfLastLevelElements *
numTablesPerNs
+ val maxPossibleTables = nAryTree.numberOfLastLevelElements * numTablesPerNs
Review Comment:
Good callout on the annotation.
Initially I thought to create my own dataset for this workload (i.e. a flat
namespace structure), but I realized it's fairly easy to use the existing one.
`maxPossibleTables` was really convenient for getting the number of tables in
total, which is the main thing this workload cares about. So if possible I
think it makes sense to continue to use it.
I thought for a while about how to make the sampling with with
`numTablesMax` set, but just gave up and decided I'll go with
`maxPossibleTables` for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
