snazy commented on code in PR #1897:
URL: https://github.com/apache/polaris/pull/1897#discussion_r2150066627
##########
.github/workflows/gradle.yml:
##########
@@ -33,65 +33,89 @@ on:
branches: [ "main" ]
jobs:
- build:
+ unit-tests:
Review Comment:
Need to update `.asf.yaml` as well
##########
.github/workflows/gradle.yml:
##########
@@ -33,65 +33,89 @@ on:
branches: [ "main" ]
jobs:
- build:
+ unit-tests:
+ name: Unit Tests
runs-on: ubuntu-latest
permissions:
contents: read
-
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Set up JDK 21
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4
with:
java-version: '21'
distribution: 'temurin'
-
- # Configure Gradle for optimal use in GiHub Actions, including caching
of downloaded dependencies.
- # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
- name: Setup Gradle
uses:
gradle/actions/setup-gradle@ac638b010cf58a27ee6c972d7336334ccaf61c96 # v4
with:
- # The setup-gradle action fails, if the wrapper is not using the
right version or is not present.
- # Our `gradlew` validates the integrity of the `gradle-wrapper.jar`,
so it's safe to disable this.
validate-wrappers: false
-
- - name: Code style checks and tests
- run: ./gradlew --continue check
-
- - name: Check Maven publication
- run: ./gradlew publishToMavenLocal sourceTarball
-
+ - name: Run unit tests
+ run: |
+ ./gradlew check sourceTarball distTar distZip publishToMavenLocal \
+ -x :polaris-quarkus-service:test \
+ -x :polaris-quarkus-admin:test \
+ -x intTest --continue
- name: Archive test results
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
# v4
if: always()
with:
- name: upload-test-artifacts
+ name: upload-unit-test-artifacts
path: |
**/build/test-results/**
- - name: Stop Gradle daemons
- run: ./gradlew --stop
+ quarkus-tests:
+ name: Quarkus Tests
+ runs-on: ubuntu-latest
+ permissions:
+ contents: read
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+ - name: Set up JDK 21
+ uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4
+ with:
+ java-version: '21'
+ distribution: 'temurin'
+ - name: Setup Gradle
+ uses:
gradle/actions/setup-gradle@ac638b010cf58a27ee6c972d7336334ccaf61c96 # v4
+ with:
+ validate-wrappers: false
+ - name: Run Quarkus tests
+ run: |
+ ./gradlew \
+ :polaris-quarkus-service:test \
+ :polaris-quarkus-admin:test \
+ --continue
+ - name: Archive test results
+ uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
# v4
+ if: always()
+ with:
+ name: upload-quarkus-test-artifacts
+ path: |
+ **/build/test-results/**
- # Ensure that the build works properly when building against the "latest
greatest" Java version
+ integration-tests:
+ name: Integration Tests
+ runs-on: ubuntu-latest
+ permissions:
+ contents: read
+ steps:
+ - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Set up JDK 23
Review Comment:
23 is EOL - and 24 won't work. Probably better to go back to 21?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
