dimas-b commented on code in PR #1838:
URL: https://github.com/apache/polaris/pull/1838#discussion_r2144145119
##########
polaris-core/src/main/java/org/apache/polaris/core/catalog/PolarisCatalogHelpers.java:
##########
@@ -62,20 +61,28 @@ public static Namespace getParentNamespace(Namespace
namespace) {
return Namespace.of(parentLevels);
}
- public static List<Namespace> nameAndIdToNamespaces(
- List<PolarisEntity> catalogPath, List<PolarisEntity.NameAndId> entities)
{
+ public static Namespace nameAndIdToNamespace(
Review Comment:
This is a side effect of introducing the `Page.map()` method. Pages are
produced by persistence and hold the low-level "data pointer". The new `map()`
method allows transforming the items in a `Page` while maintaining the "data
pointer" (and not having to "manually" pass it around).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]