dimas-b commented on code in PR #1838: URL: https://github.com/apache/polaris/pull/1838#discussion_r2140576716
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageTokenUtil.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.persistence.pagination; + +import static com.google.api.client.util.Preconditions.checkArgument; + +import jakarta.annotation.Nullable; +import java.util.Optional; + +public final class PageTokenUtil { Review Comment: done ########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/Page.java: ########## @@ -18,25 +18,84 @@ */ package org.apache.polaris.core.persistence.pagination; +import static java.util.Spliterators.iterator; + +import jakarta.annotation.Nullable; +import java.util.ArrayList; +import java.util.Iterator; import java.util.List; +import java.util.function.Function; +import java.util.stream.Collectors; +import java.util.stream.Stream; /** * An immutable page of items plus their paging cursor. The {@link PageToken} here can be used to * continue the listing operation that generated the `items`. */ public class Page<T> { - public final PageToken pageToken; - public final List<T> items; + private final PageRequest request; + private final PageToken nextToken; + private final List<T> items; - public Page(PageToken pageToken, List<T> items) { - this.pageToken = pageToken; + private Page(PageRequest request, PageToken nextToken, List<T> items) { + this.request = request; + this.nextToken = nextToken; this.items = items; } - /** - * Used to wrap a {@link List<T>} of items into a {@link Page <T>} when there are no more pages - */ - public static <T> Page<T> fromItems(List<T> items) { - return new Page<>(new DonePageToken(), items); + public static <T> Page<T> allItems(List<T> items) { + return new Page<>(PageRequest.readEverything(), () -> null, items); + } + + public static <T> Page<T> fromStream( Review Comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
