gfakbar20 commented on code in PR #1831:
URL: https://github.com/apache/polaris/pull/1831#discussion_r2133400149


##########
tools/version/build.gradle.kts:
##########
@@ -32,7 +32,9 @@ description =
 val syncNoticeAndLicense by
   tasks.registering(Sync::class) {
     // Have to manually declare the inputs of this task here on top of the 
from/include below
-    inputs.files(rootProject.layout.files("NOTICE*", "LICENSE*", 
"version.txt"))
+    inputs.files(fileTree(rootProject.rootDir) {
+      include("NOTICE*", "LICENSE*", "version.txt")
+    })

Review Comment:
   So, after running `checkstyle` task, there are several task that follows 
like this (`syncNoticeAndLicense`) and `openApiGenerate`. What is the expected 
behavior? are those supposed to run after checkstyle or no? From my local, 
`syncNoticeAndLicense` always failed running. If it not happened on other 
device and not needed for checkstyle task in polaris, I will remove this and 
try to fix the checkstyle plugin config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to