dimas-b commented on code in PR #1802:
URL: https://github.com/apache/polaris/pull/1802#discussion_r2129135094
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java:
##########
@@ -206,6 +215,17 @@ public void runWithinTransaction(TransactionCallback
callback) throws SQLExcepti
});
}
+ public Integer execute(Connection connection, QueryGenerator.PreparedQuery
preparedQuery)
+ throws SQLException {
+ try (PreparedStatement statement =
connection.prepareStatement(preparedQuery.sql())) {
Review Comment:
This code appears to be called one per entity in `writeEntities`. I believe
we should try and refactor the code to do `prepareStatement` once, execute many
in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
