HonahX commented on code in PR #1812:
URL: https://github.com/apache/polaris/pull/1812#discussion_r2127687984
##########
persistence/eclipselink/src/test/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreManagerTest.java:
##########
@@ -90,6 +90,7 @@ protected PolarisTestMetaStoreManager
createPolarisTestMetaStoreManager() {
return new PolarisTestMetaStoreManager(
new TransactionalMetaStoreManagerImpl(),
new PolarisCallContext(
+ () -> "testRealm",
Review Comment:
This helps remove the `CallContext.of()` in
[BasePolarisMetaStoreManagerTest](https://github.com/apache/polaris/pull/1812/files/433255ebe9e20545a24968170891bdf07ba36c25#diff-30b068986c222deac39e61068f6dfd6bdffc6a5d82474c935814a81a186d164eL110),
where some tests have the following pattern
```
@Test
protected void testCreateEntitiesAlreadyExisting() {
PolarisMetaStoreManager metaStoreManager =
polarisTestMetaStoreManager.polarisMetaStoreManager;
CallContext callCtx =
CallContext.of(() -> "testRealm",
polarisTestMetaStoreManager.polarisCallContext);
if (CallContext.getCurrentContext() == null) {
CallContext.setCurrentContext(callCtx);
}
```
The `polarisTestMetaStoreManager` above is initialized in
`PolarisEclipseLinkMetaStoreManagerTest` (and other persistence specific test
class)
BTW, this change will disappear anyway with Yun's
https://github.com/apache/polaris/pull/1813 : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
