eric-maynard commented on code in PR #1772:
URL: https://github.com/apache/polaris/pull/1772#discussion_r2122333066
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -212,6 +212,14 @@ public IcebergCatalog(
this.polarisEventListener = polarisEventListener;
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (isValidIdentifier(identifier)) {
+ return newTableOps(identifier).current() != null;
Review Comment:
I see. For context, this will force a trip to object storage to load the
table's metadata, which #433 (being re-implemented) proposes to skip via a trip
to the metastore. I know this method isn't called often, but it's a shame if we
have to lose that performance optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
