dimas-b commented on code in PR #1758:
URL: https://github.com/apache/polaris/pull/1758#discussion_r2121946375
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -65,6 +76,35 @@ public interface PolarisConfigurationStore {
return configValue != null ? configValue : defaultValue;
}
+ /**
+ * Retrieve the current value for a configuration key for a given realm. May
be null if not set.
+ *
+ * @param realmContext the realm context
+ * @param configName the name of the configuration key to check
+ * @return the current value set for the configuration key for the given
realm, or null if not set
+ * @param <T> the type of the configuration value
+ */
+ default <T> @Nullable T getConfiguration(@Nonnull RealmContext realmContext,
String configName) {
Review Comment:
Removing -1 in the interest of making progress. There is only one
implementation, which appears to processes both lookup call paths correctly (as
far as I can tell from the diff). I'd be fine merging in this state after the
other minor comments are addressed.
@gh-yzou : Would you mind opening a GH for followup?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -65,6 +76,35 @@ public interface PolarisConfigurationStore {
return configValue != null ? configValue : defaultValue;
}
+ /**
+ * Retrieve the current value for a configuration key for a given realm. May
be null if not set.
+ *
+ * @param realmContext the realm context
+ * @param configName the name of the configuration key to check
+ * @return the current value set for the configuration key for the given
realm, or null if not set
+ * @param <T> the type of the configuration value
+ */
+ default <T> @Nullable T getConfiguration(@Nonnull RealmContext realmContext,
String configName) {
Review Comment:
Removing -1 in the interest of making progress. There is only one
implementation, which appears to processes both lookup call paths correctly (as
far as I can tell from the diff). I'd be fine merging in this state after the
other minor comments are addressed.
@gh-yzou : Would you mind opening a GH issue for followup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
