dimas-b commented on code in PR #1707:
URL: https://github.com/apache/polaris/pull/1707#discussion_r2112772169
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/EclipseLinkProductionReadinessChecks.java:
##########
@@ -36,7 +37,14 @@ public class EclipseLinkProductionReadinessChecks {
LoggerFactory.getLogger(EclipseLinkProductionReadinessChecks.class);
@Produces
- public ProductionReadinessCheck checkJdbcUrl(EclipseLinkConfiguration
eclipseLinkConfiguration) {
+ public ProductionReadinessCheck checkJdbcUrl(
Review Comment:
The purpose of this check is to warn about H2, which is also possible with
JDBC persistence... Should we make a similar check for JDBC?
In that case, we do not have to bind to `MetaStoreManagerFactory`, but can
validate connection URL as the `DataSource` level. H2 should yield a production
warning regardless of where the `DataSource` is injected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
