flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2913352451

   The only solution I found for excluding `quarkus-app-dependencies.txt` from 
server and admin module is to zip it, in which case, the distribution module 
has to unzip it. I don't think it's worth to add additional zip and unzip 
process. My concern is that it is a complicated solution with worse build perf.
   ```
   val quarkusAppZip by
     tasks.registering(Zip::class) {
       dependsOn(quarkusBuild)
       archiveClassifier.set("dist") 
       from(layout.buildDirectory.dir("quarkus-app")) {
         exclude("quarkus-app-dependencies.txt")
       }
     }
   
   artifacts {
     add(quarkusRunner.name, provider { 
quarkusBuild.get().fastJar.resolve("quarkus-run.jar") }) {
       builtBy(quarkusBuild)
     }
   
     add("distributionElements", quarkusAppZip) {
       builtBy(quarkusAppZip) 
     }
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to