flyrain commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2105466575
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -287,4 +294,25 @@ public static void enforceFeatureEnabledOrThrow(
+ "This should only be set to 'true' for tests!")
.defaultValue(false)
.buildFeatureConfiguration();
+
+ public static final PolarisConfiguration<Integer> METADATA_CACHE_MAX_BYTES =
+ PolarisConfiguration.<Integer>builder()
+ .key("METADATA_CACHE_MAX_BYTES")
+ .catalogConfig("polaris.config.metadata-cache-max-bytes")
+ .description(
+ "If nonzero, the approximate max size a table's metadata can be
in order to be cached in the persistence"
+ + " layer. If zero, no metadata will be cached or served
from the cache. If -1, all metadata"
+ + " will be cached.")
+ .defaultValue(Constants.METADATA_CACHE_MAX_BYTES_NO_CACHING)
Review Comment:
Not a blocker: It's reasonable to turn it off by default. Do we have a
recommended size so that users/admins could use it without additional
evaluation work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
