dimas-b commented on code in PR #1663: URL: https://github.com/apache/polaris/pull/1663#discussion_r2104794680
########## codestyle/errorprone-rules.properties: ########## @@ -227,6 +227,12 @@ UseCorrectAssertInTests=ERROR ConstantPatternCompile=ERROR # Variables initialized with Pattern#compile calls on constants can be constants +ObjectsHashCodePrimitive=ERROR +# Objects.hashCode(Object o) should not be passed a primitive value + +OptionalMapToOptional=ERROR +# Mapping to another Optional will yield a nested Optional. Did you mean flatMap? Review Comment: The need to nested `Optional` is quite hypothetical, but the error pattern is common in my experience. I think the check is worth enforcing for now. We can remove it if/when we have to. ########## codestyle/errorprone-rules.properties: ########## @@ -227,6 +227,12 @@ UseCorrectAssertInTests=ERROR ConstantPatternCompile=ERROR # Variables initialized with Pattern#compile calls on constants can be constants +ObjectsHashCodePrimitive=ERROR +# Objects.hashCode(Object o) should not be passed a primitive value + +OptionalMapToOptional=ERROR +# Mapping to another Optional will yield a nested Optional. Did you mean flatMap? Review Comment: The need for nested `Optional` is quite hypothetical, but the error pattern is common in my experience. I think the check is worth enforcing for now. We can remove it if/when we have to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
