flyrain commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103838169


##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -176,7 +179,9 @@ Finally, note that we include the `iceberg-aws-bundle` 
package here. If your tab
 
 Refresh the Docker container with the user's credentials:
 ```shell
-docker compose -f getting-started/eclipselink/docker-compose.yml up -d
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml 
stop spark-sql
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml rm 
-f spark-sql
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml up 
-d --no-deps spark-sql

Review Comment:
   Same here, prefer to have a JDBC example. 



##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -237,14 +242,15 @@ org.apache.iceberg.exceptions.ForbiddenException: 
Forbidden: Principal 'quicksta
 Refresh the Docker container with the user's credentials:
 
 ```shell
-docker compose -f getting-started/eclipselink/docker-compose.yml down trino
-docker compose -f getting-started/eclipselink/docker-compose.yml up -d
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml 
stop trino
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml rm 
-f trino
+docker compose -p polaris -f getting-started/eclipselink/docker-compose.yml up 
-d --no-deps trino

Review Comment:
   I'd prefer to provide jdbc examples instead of eclipseLink ones here, we 
could do that in a follow-up PR though. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to