adnanhemani commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103679535
##########
getting-started/assets/postgres/pg_hba.conf:
##########
@@ -0,0 +1,2 @@
+host all all all md5
Review Comment:
I didn't find the need for this personally when running against the provided
Postgres Docker image or against cloud providers. Are you using one of these
deployment options?
##########
getting-started/eclipselink/docker-compose-bootstrap-db.yml:
##########
@@ -25,7 +25,7 @@ services:
polaris.persistence.type: eclipse-link
polaris.persistence.eclipselink.configuration-file:
/deployments/config/eclipselink/persistence.xml
volumes:
- - ../assets/eclipselink/:/deployments/config/eclipselink
Review Comment:
Let's revert the changes related to the `assets` folder. There's a better
solution than playing with the relative paths in #1610 that I think would be
best to use instead - but we're slight a slight bit off from merging that PR
through just yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
