flyrain commented on code in PR #1646:
URL: https://github.com/apache/polaris/pull/1646#discussion_r2101415105
##########
getting-started/jdbc/docker-compose.yml:
##########
@@ -29,18 +29,22 @@ services:
# Optional, allows attaching a debugger to the Polaris JVM
- "5005:5005"
environment:
- - JAVA_DEBUG=true
- - JAVA_DEBUG_PORT=*:5005
- - POLARIS_PERSISTENCE_TYPE=relational-jdbc
- - POLARIS_PERSISTENCE_RELATIONAL_JDBC_MAX_RETRIES=5
- - POLARIS_PERSISTENCE_RELATIONAL_JDBC_INITIAL_DELAY_IN_MS=100
- - POLARIS_PERSISTENCE_RELATIONAL_JDBC_MAX_DELAY_IN_MS=5000
- - QUARKUS_DATASOURCE_DB_KIND=pgsql
- - QUARKUS_DATASOURCE_JDBC_URL=${QUARKUS_DATASOURCE_JDBC_URL}
- - QUARKUS_DATASOURCE_USERNAME=${QUARKUS_DATASOURCE_USERNAME}
- - QUARKUS_DATASOURCE_PASSWORD=${QUARKUS_DATASOURCE_PASSWORD}
- - POLARIS_REALM_CONTEXT_REALMS=POLARIS
- - QUARKUS_OTEL_SDK_DISABLED=true
+ JAVA_DEBUG: true
+ JAVA_DEBUG_PORT: "*:5005"
+ POLARIS_PERSISTENCE_TYPE: relational-jdbc
+ POLARIS_PERSISTENCE_RELATIONAL_JDBC_MAX_RETRIES: 5
+ POLARIS_PERSISTENCE_RELATIONAL_JDBC_INITIAL_DELAY_IN_MS: 100
+ POLARIS_PERSISTENCE_RELATIONAL_JDBC_MAX_DELAY_IN_MS: 5000
+ QUARKUS_DATASOURCE_DB_KIND: pgsql
+ QUARKUS_DATASOURCE_JDBC_URL: $QUARKUS_DATASOURCE_JDBC_URL
+ QUARKUS_DATASOURCE_USERNAME: $QUARKUS_DATASOURCE_USERNAME
+ QUARKUS_DATASOURCE_PASSWORD: $QUARKUS_DATASOURCE_PASSWORD
Review Comment:
nit: use `${QUARKUS_DATASOURCE_JDBC_URL}` to keep it consistent with
`${CLIENT_ID}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
