MonkeyCanCode commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096800119
##########
getting-started/eclipselink/docker-compose.yml:
##########
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog",
--conf,
"spark.sql.catalog.quickstart_catalog.uri=http://polaris:8181/api/catalog";,
- --conf,
"spark.sql.catalog.quickstart_catalog.credential=${USER_CLIENT_ID}:${USER_CLIENT_SECRET}",
+ --conf,
"spark.sql.catalog.quickstart_catalog.credential=${CLIENT_ID}:${CLIENT_SECRET}",
Review Comment:
I did noticed this one last night and assuming there is intensional.
However, going through the quickstart guide, this is supposed to be the
credential created at the end of the polaris CLI. But `USER_CLIENT_ID` and
`USER_CLIENT_SECRET` is never defined in this context I believed. As an
end-user tries to bring up setup via docker compose, there is no relation to
the polaris CLI.
Now assuming we want to keep it this way, an end-user can't really define
this one until polaris CLI returns the value back (which needed to bring up
docker compose first, run polaris CLI for entities creation, then restart
spark-sql to have this be effective). This restart workflow is really odd imo
and we should replace it with other more automated workflow.
If this is causing regression, I can change it back. But I don't think we
ask user to follow the restart workflow as it is really tedious imo.
Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
