gh-yzou commented on code in PR #1543:
URL: https://github.com/apache/polaris/pull/1543#discussion_r2096495983


##########
spec/polaris-catalog-apis/generic-tables-api.yaml:
##########
@@ -212,6 +214,8 @@ components:
         - `properties` properties for the generic table passed on creation
         
         - `doc` comment or description for the generic table
+        
+        - `location` location for the table

Review Comment:
   Hi @dimas-b Thanks a lot for the information! Is that for Iceberg tables, 
from the description, it does seems for Iceberg tables. I think for iceberg 
tables, we all agree that it can have multiple table locations, in fact, 
@dennishuo is looking into proposing new "locations" fields for Iceberg. Since 
generic table is not designed for iceberg usage today, so far i don't see it is 
necessary.
   
   I am also open to have locations instead of location to accommodate future 
possibilities, I am little bit worried that no one will need it in such way, 
and it could introduce potential confusion to users. 
   An alternative we can do is if in the future if we encounter table formats 
that could allow multiple locations, we can introduce extra reserved property 
key to record extra locations for those table formats.
   
   WDYT? i will also sent it on the mailing thread as a record



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to