snazy commented on PR #1609:
URL: https://github.com/apache/polaris/pull/1609#issuecomment-2890460952

   TBH, I don't understand the point of "vulnerabilities" and how the 
bundle-jar would solve this.
   
   We already use [very recent versions of the 
awssdk](https://github.com/apache/polaris/blob/f4ecb6c991c8992d49120a544e1ff44359cffe05/gradle/libs.versions.toml#L42-L43)
 - so the versions in the "bundle-jar" are already older. The right way IMHO 
would be to _not_ use the gcp-bundle but instead use up-to-date versions of it 
directly.
   
   I see more issues with using the bundle-jar, especially _duplicate_ classes 
on the class path, because uber-jars silently bring these duplicate classes and 
all the "joy" of having duplicate classes from different versions on the 
classpath.
   
   These "bundle-jars" are probably nice in some cases, but I do not think that 
those are a good fit for Polaris.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to