dimas-b commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2095886994
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
The secret comes from `getting-started/jdbc/docker-compose-bootstrap-db.yml`
(added under #1470).
Having this value set up front creates a backwards logical dependency, IMHO
:thinking:
Since `docker-compose-postgres.yml` depends on the root secret and takes it
from the user's env., I think `docker-compose-bootstrap-db.yml` should take the
root secret from the user's env. too (and fail if it is not provided).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
